Implement type hints for most functions #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix wrong documentation for types/names Remove python setup.py install instructions and add virtualenv req to pip Fixes santiher#6
|
@santiher Are you interested in continuing to maintain this project? I see last commit was 5 years ago. I could take over this repo + PyPI if you're uninterested, better that than having to fork it :) EDIT: Forked it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented type hints. Couple are missing, but most functions are covered.
Requires Python 3.11+, so I took it upon myself to tag a 3.0.0 version in the changelog, as 2.0.0 supports 2.7+.
Fixed some wrong documentation types and names.
Removed
python setup.pyinstall instructions and added venv req flag to pip calls.Also bumps up the requests dependency, so this supersedes #6.