Skip to content

fix(deps): update eslint version to fix peer dep conflict#207

Open
joshuata wants to merge 12 commits intosatisfactorymodding:stagingfrom
joshuata:joshuata/eslint
Open

fix(deps): update eslint version to fix peer dep conflict#207
joshuata wants to merge 12 commits intosatisfactorymodding:stagingfrom
joshuata:joshuata/eslint

Conversation

@joshuata
Copy link
Contributor

@joshuata joshuata commented Nov 8, 2024

Any change to packages was previously causing issues due to conflicting peer dependencies. This updates to the recommended sveltekit eslint config and recent eslint versions

budak7273 and others added 3 commits October 12, 2024 12:45
…irect (satisfactorymodding#200)

* fix: language flag icons showing with incorrect colors
(ex. germany white instead of black)

* feat: add es, hu, ko, pt-BR, to language picker. widen dropdown, setup overflow scrolling

* fix: typo

* feat: redirect old /sml-versions page to /mod/SML
* feat: added virustotal results to versions screen

* fix: remove canedit from vt results

* fix: update to virustotal_results

* fix: move thead to tbody/make text translatable

---------

Co-authored-by: Rob B <computerguy440+gh@gmail.com>
Any change to packages was previously causing issues due to
conflicting peer dependencies. This updates to the recommended
sveltekit eslint config and recent eslint versions
@vercel
Copy link

vercel bot commented Nov 8, 2024

@joshuata is attempting to deploy a commit to the satisfactorymodding Team on Vercel.

A member of the Team first needs to authorize it.

joshuata and others added 4 commits November 15, 2024 15:35
Currently the repo requires commitlint to pass, but there is no notification until commit passes.
This adds a prompt when commiting to help devs
…odding#211)

* Add Satisfactory Interactive Maps by TH.GL

* Contain images with different aspect ratio

* Prettify
Fixes satisfactorymodding#131. Explicitly setting the cookie hostname was causing
cookie.remove to fail.

Co-authored-by: Rob B <computerguy440+gh@gmail.com>
Copy link
Member

@budak7273 budak7273 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When trying to run this locally, I see new warnings that haven't been resolved. I'm not sure how your commit passed linting without triggering these warnings - are the new configs not pinned to a specific version of linter rules?

I tried to fix some of these warnings and commit, but it seems like these changes have also made all of my git clients error when trying to skip commit hooks. Not sure if this is a problem on my end or with the changes.

@budak7273 budak7273 moved this from 🆕 New to 👀 In review in Mod Repository (SMR) Mar 30, 2025
joshuata and others added 3 commits March 29, 2025 22:35
* fix: migrate away from appshell

fixes satisfactorymodding#208

* fix: prettier errors in base layout

---------

Co-authored-by: Rob B <computerguy440+gh@gmail.com>
@joshuata
Copy link
Contributor Author

I left the warnings since I didn't want to make big changes based on a config change I wasn't sure would be accepted. We can absolutely fix them, I just wanted to be careful

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 👀 In review

Development

Successfully merging this pull request may close these issues.

4 participants