Xfstests generic fixes kcai#7
Open
KevinCai319 wants to merge 3 commits intomasterfrom
Open
Conversation
Removed line which decremented pointer when buffer is full, which caused a double-write.
File currently opened in program becomes invalid the moment it gets deleted (after a rename(), but should still be valid until program closes, with st_nlink=0 Switching from hasNoLinks() to checking !isActive() seems to work. Second issue has to deal with nlinks overflowing. When one file is renamed in FuseRename() and there is already a existing file with the same name, the existing file is deleted. During this operation nlink should go down by 1 for regular files. For empty directories, (Attempt to decrement link count twice from . and ..), but one decrement was already done for regular files, causing overflow.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes from xfstests generic/006, generic/035.
102->63+(3?) failed test cases. (Did not test generic/013, generic/014, generic/129)