Skip to content

Update Date and Time Format #318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Jiatonglii22 wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Update Date and Time Format #318

Jiatonglii22 wants to merge 6 commits into from

Conversation

@Jiatonglii22
Copy link
Contributor

@Jiatonglii22 Jiatonglii22 commented Apr 1, 2023

  • added helper for date and time format
  • switched 'started_at' and 'ended_at' for more intuitive editing in organization timeline form.html
  • added gem 'simple_form'

@Jiatonglii22 Jiatonglii22 self-assigned this Apr 1, 2023
merichar
merichar requested changes Apr 2, 2023
View reviewed changes
Copy link
Member

@merichar merichar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're removing simpleform. Can you replace the simple_form reference instead?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@merichar merichar merichar requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@Jiatonglii22 Jiatonglii22

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Jiatonglii22 @merichar