Skip to content

Stop interning all PlainFile paths - #26688

Open
SolalPirelli wants to merge 1 commit into
scala:mainfrom
dotty-staging:solal/perf3
Open

Stop interning all PlainFile paths#26688
SolalPirelli wants to merge 1 commit into
scala:mainfrom
dotty-staging:solal/perf3

Conversation

@SolalPirelli

@SolalPirelli SolalPirelli commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

The intern call shows up in profiles. Benchmarks say it doesn't actually help later.

Have you relied on LLM-based tools in this contribution?

No

How was the solution tested?

Covered by existing tests (this is a refactoring)

@mbovel

mbovel commented Aug 4, 2026

Copy link
Copy Markdown
Member

Benchmarks started. Workflow run.

@mbovel

mbovel commented Aug 5, 2026

Copy link
Copy Markdown
Member

Benchmarks completed. Overview.

@SolalPirelli
SolalPirelli marked this pull request as ready for review August 6, 2026 06:46
@SolalPirelli
SolalPirelli requested a review from mbovel August 6, 2026 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants