LogicalPackagesProvider: use the compilation Context - #26776
Open
SolalPirelli wants to merge 5 commits into
Open
LogicalPackagesProvider: use the compilation Context#26776SolalPirelli wants to merge 5 commits into
SolalPirelli wants to merge 5 commits into
Conversation
tgodzik
reviewed
Aug 11, 2026
| search, | ||
| driver, | ||
| () => InteractiveDriver(driverSettings, driver.logicalRootPackage), | ||
| () => InteractiveDriver(driverSettings, driver.logicalRootPackageExtractor), |
Contributor
There was a problem hiding this comment.
Will this not recreate the logicalRootPackage on each completion? It can be quite heavy since we parse each file in the sourcepath.
Contributor
Author
There was a problem hiding this comment.
It'll create it once per instance of ContextBase (since the platform is created in initialize() and cached in a field).
Do we create more than one of those per source path?
Contributor
There was a problem hiding this comment.
In this case it would be worth to copy over the context ot the logicalRootPackage itself, otherwise we will create a new instance of ContextBase on the fallback here.
Contributor
Author
There was a problem hiding this comment.
I added caching
SolalPirelli
force-pushed
the
solal/logical-provider-context
branch
from
August 11, 2026 13:54
3c8523e to
741de6a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensures files are parsed with the right encoding, etc.
I need this for an unrelated refactoring I'm doing.
Have you relied on LLM-based tools in this contribution?
No
How was the solution tested?
Covered by existing tests (this is a refactoring)