Added Drainable implementation to ProtoInputStream#2055
Open
laoqiu233 wants to merge 1 commit intoscalapb:masterfrom
Open
Added Drainable implementation to ProtoInputStream#2055laoqiu233 wants to merge 1 commit intoscalapb:masterfrom
laoqiu233 wants to merge 1 commit intoscalapb:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current default output stream that the scalapb marshaller uses does not support the Drainable interface from grpc-java, which becomse a problem here where high performance code are expected to support it to avoid copying of the serialized protobuf.
This relatively simple fix allowed us to optimize a performance critical and high throughput service, and after deploying it to production we managed to cut a few GB of heap usage in the runtime and significantly lowered the heap presuure, but we did not get noticible benefit in timings. (Although for bigger protobuf messages it could make the timings a lot better by avoiding the copying)