fix Issue#152 IndexError in dram_latency.py#153
Merged
iamsarbartha merged 1 commit intoscalesim-project:mainfrom Nov 4, 2025
Merged
fix Issue#152 IndexError in dram_latency.py#153iamsarbartha merged 1 commit intoscalesim-project:mainfrom
iamsarbartha merged 1 commit intoscalesim-project:mainfrom
Conversation
Collaborator
|
Thanks @GeorgeLin200100 for finding and fixing this corner case. Since the empty slice does not create DRAM transactions, this leads to the error. I approve this fix. |
iamsarbartha
reviewed
Nov 4, 2025
Collaborator
iamsarbartha
left a comment
iamsarbartha
left a comment
There was a problem hiding this comment.
This fix prevents a code exit for empty last slice
iamsarbartha
approved these changes
Nov 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #152 with minimal changes to scripts/dram_latency.py.