-
Notifications
You must be signed in to change notification settings - Fork 5
Expanded comments and simplified calculations on tx_device #105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Toreil
commented
Jul 11, 2025
- Extra comments were added to try and make the communication between the various buffers and the card easier to understand.
- There were one or two instances of multiple variables being defined containing the same thing (memory addresses of the buffers) which has been removed.
- The calculation for the ring_buffer_position was very complicated but in the end a lot of the steps were unnecessary. In the original code it was creating a pointer to a slice of the ring buffer and then getting the memory location of that slice, in the new code it calculates that memory location directly from the location of the ring buffer and the memory offset of the slice.
Coverage Report
|
schote
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The renaming makes sense, but I would like to avoid introducing abbreviations for the variable names and would generally keep them to a minimum. I.e. rather use data_buffer_address than data_buffer_addr. I think num_ is fine, but for channel we could also just use the long version. I think that saves us a large glossary and improves readability. What do you think @Toreil ?