Skip to content

Conversation

ariostas
Copy link
Collaborator

In #3543 I missed testing the cuda kernel tests that are generated.

@ariostas
Copy link
Collaborator Author

@ianna some of the tests-cuda-kernels-explicit tests are failing. Do you know if this is expected?

@ianna
Copy link
Collaborator

ianna commented Jun 17, 2025

@ianna some of the tests-cuda-kernels-explicit tests are failing. Do you know if this is expected?

No, they all used to pass ... I'll have a look. Thanks!

@ariostas
Copy link
Collaborator Author

I thought that maybe not installing pytest-xdist would fix things since @ikrommyd also reported unexpected failures in #3459, but it didn't fix it.

@ikrommyd
Copy link
Collaborator

ikrommyd commented Jun 17, 2025

I thought that maybe not installing pytest-xdist would fix things since @ikrommyd also reported unexpected failures in #3459, but it didn't fix it.

No no, xdist existing is fine since it's not being used. I wasn't getting any unexpected errors without xdist on my RTX 4080

Copy link
Collaborator

@ianna ianna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ariostas - this looks great! Please, merge it when you are done with it. Thanks!

@ariostas
Copy link
Collaborator Author

Thanks for fixing it, @ianna!

@ariostas ariostas marked this pull request as ready for review June 23, 2025 18:43
@ariostas ariostas merged commit 77f280e into main Jun 23, 2025
43 checks passed
@ariostas ariostas deleted the ariostas/test_cuda_kernels branch June 23, 2025 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants