feat: more flexible filter specification to allow overriding and appending to filters#310
Open
alexander-held wants to merge 8 commits intomasterfrom
Open
feat: more flexible filter specification to allow overriding and appending to filters#310alexander-held wants to merge 8 commits intomasterfrom
alexander-held wants to merge 8 commits intomasterfrom
Conversation
Codecov ReportBase: 100.00% // Head: 100.00% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #310 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 23 23
Lines 2023 2032 +9
Branches 331 335 +4
=========================================
+ Hits 2023 2032 +9
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
4277b20 to
e15555b
Compare
e15555b to
01f7602
Compare
01f7602 to
d9813f8
Compare
3005587 to
19ff3e8
Compare
19ff3e8 to
95d5edc
Compare
…ough routing and template builder
… general config dict
95d5edc to
729a5d8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements a new approach for filter specification outlined in #307 (comment).
Breaking changes:
Filteroption in configs is replaced byFilters, which takes a dictionary instead of a stringFiltersneeds a user-defined name (Nameproperty) and the filter itself (a string, asFilter)to-do:
apply_to_all_templates, or whether to wrap required info like currently done with ntuple and histogram paths (if not, that should probably be refactored in a second step)resolves #307