feat: implementing impact calculations using auxiliary data shifting method#516
Open
MoAly98 wants to merge 31 commits intoscikit-hep:masterfrom
Open
feat: implementing impact calculations using auxiliary data shifting method#516MoAly98 wants to merge 31 commits intoscikit-hep:masterfrom
MoAly98 wants to merge 31 commits intoscikit-hep:masterfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #516 +/- ##
===========================================
- Coverage 100.00% 99.86% -0.14%
===========================================
Files 22 22
Lines 2096 2219 +123
Branches 291 311 +20
===========================================
+ Hits 2096 2216 +120
- Misses 0 1 +1
- Partials 0 2 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
alexander-held
left a comment
There was a problem hiding this comment.
We should first get in #515 before this one, right?
…ting statistical uncertainty in non-np-shift methods
This was referenced Mar 17, 2025
Status: Blocked ❌Issues blocking this PR:This comment was automatically written by the Blocking Issues bot, and this PR will be monitored for further progress. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #514.
Blocked by #519.
To-do:
NotImplementedErrorraises