TODO: Remove workaround in boolean_masks_to_categorical_integers function #1361
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft as it hits a still-extant limitation in awkward which prevents actually removing this TODO for now:
scikit-hep/awkward#3312 (comment)
@ikrommyd tested changing the prototype array's dtype to > int8, which resolves the immediate error. Given the name and what it seems to do, it's unclear to me if there should be a try-except logic that starts with int8 and swaps when it reaches overflow, or if this needs some different approach, or if just brute-force swapping to int64 is sufficient.
If and when such an extension is added to awkward and that becomes the minimal version for coffea, this can be further developed (
irregular_mask_sequel
will need to be validated as having identical contents to theirregular_mask
, at which point the slice logic can be deprecated and removed)