feat: implement CMS Type-1 MET correction in CorrectedMETFactory#1537
Open
alefisico wants to merge 5 commits intoscikit-hep:masterfrom
Open
feat: implement CMS Type-1 MET correction in CorrectedMETFactory#1537alefisico wants to merge 5 commits intoscikit-hep:masterfrom
alefisico wants to merge 5 commits intoscikit-hep:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the full CMS Type-1 MET correction recipe in
CorrectedMETFactory, addressing the remaining open item from #1064. (This feature was asked by @mcremone)The previous fix (commit 6dfd4ad) corrected the sign and
_origreference bugs, but the factory still did not implement the proper Type-1 correction: it was missing muon subtraction, L1-only JEC, EM fraction cuts, and theCorrT1METJetlow-pT jet collection.This PR adds a new Type-1 mode that follows the official CMS procedure as described in the JME General Meeting slides (Feb 2026):
pt_noMuL1L2L3 > 15 GeVandEM fraction < 0.9RawMET -= Σ(pt_noMuL1L2L3 - pt_noMuL1)for bothJetandCorrT1METJetcollectionsBehaviour
Type-1 mode is opt-in and backward compatible. Legacy behavior is completely unchanged when the new parameters are not provided.
The JEC correctors are duck-typed — both
FactorizedJetCorrectorandCorrectionLibJECwork.Implementation details
awkward.ziprecords (not tuples) for dask-awkward compatibilityCorrectionLibJECcompatibilityvaried_pt / nominal_ptto scalept_noMuL1L2L3, and re-apply the> 15 GeVcutCorrT1METJetcontribution stays nominal for JES/JER variations (it's not incorrected_jets)