Skip to content

Show effective bf in decay chain viewer#567

Merged
eduardo-rodrigues merged 6 commits intoscikit-hep:mainfrom
vvsagar:feature/show-effective-bf-DecayChainViewer
Apr 13, 2026
Merged

Show effective bf in decay chain viewer#567
eduardo-rodrigues merged 6 commits intoscikit-hep:mainfrom
vvsagar:feature/show-effective-bf-DecayChainViewer

Conversation

@vvsagar
Copy link
Copy Markdown
Contributor

@vvsagar vvsagar commented Apr 6, 2026

Follow-up from enhancement #561.

@vvsagar
Copy link
Copy Markdown
Contributor Author

vvsagar commented Apr 6, 2026

Hi @eduardo-rodrigues, this is just a simple PR on top of the previous one. No hurry to merge it at all, I am working on other things in parallel anyway. Wish you a nice Easter break :)

@eduardo-rodrigues eduardo-rodrigues added the enhancement New feature or request label Apr 13, 2026
@eduardo-rodrigues eduardo-rodrigues self-assigned this Apr 13, 2026
@eduardo-rodrigues
Copy link
Copy Markdown
Member

Hi. This update looks good, though I see some changes in the notebooks such as

-      "        new Lineshapes::RBW(\"rho(770)0\", rho_770_0_M, rho_770_0_W, 1.0, M_12, FF::BL2),\n",
+      "        new Lineshapes::RBW(\"rho(770)0\", rho_770_0_M, rho_770_0_W, 1.0, M_34, FF::BL2),\n",

, which I do not understand. I let @henryiii comment since this relates to his contributions ...

Could you also paste a visualisation example with your enhancement? That's useful.

Many thanks.

@vvsagar
Copy link
Copy Markdown
Contributor Author

vvsagar commented Apr 13, 2026

Oh yes, I added a visual example in the notebook I modified but I forgot that for ipynb files, diffs are not visualized.
You can see it here in the source branch in cell 17: https://github.com/vvsagar/decaylanguage/blob/feature/show-effective-bf-DecayChainViewer/notebooks/DecayLanguageDemo.ipynb

Copy link
Copy Markdown
Member

@eduardo-rodrigues eduardo-rodrigues left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see now that @henryiii gave a 👍. We're good. Merging.

@eduardo-rodrigues eduardo-rodrigues merged commit 2b5f95a into scikit-hep:main Apr 13, 2026
13 checks passed
@vvsagar vvsagar deleted the feature/show-effective-bf-DecayChainViewer branch April 14, 2026 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants