chore: [pre-commit.ci] pre-commit autoupdate#2568
Merged
Conversation
c420a9e to
11fb5c5
Compare
f606fac to
d4672a8
Compare
5adc4f7 to
5f35a85
Compare
5f35a85 to
cdb1420
Compare
1cac64d to
ab9a315
Compare
de475fa to
c8c2bfd
Compare
f2b0a46 to
4f6e571
Compare
389eacb to
0fb4e64
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2568 +/- ##
=======================================
Coverage 98.23% 98.23%
=======================================
Files 65 65
Lines 4190 4190
Branches 452 453 +1
=======================================
Hits 4116 4116
Misses 45 45
Partials 29 29
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
More typing issues: |
9f8b94c to
5c22b28
Compare
2463c57 to
21a6a62
Compare
5bcff92 to
f3b7d11
Compare
Member
|
Things are now just failing on Ruff revision requests, so this can get easily fixed up and then merged. |
f3b7d11 to
a6cb09f
Compare
f88c065 to
19101f3
Compare
updates: - [github.com/pre-commit/pre-commit-hooks: v5.0.0 → v6.0.0](pre-commit/pre-commit-hooks@v5.0.0...v6.0.0) - [github.com/astral-sh/ruff-pre-commit: v0.12.0 → v0.14.3](astral-sh/ruff-pre-commit@v0.12.0...v0.14.3) - [github.com/psf/black-pre-commit-mirror: 24.10.0 → 25.9.0](psf/black-pre-commit-mirror@24.10.0...25.9.0) - [github.com/adamchainz/blacken-docs: 1.19.1 → 1.20.0](adamchainz/blacken-docs@1.19.1...1.20.0) - [github.com/pre-commit/mirrors-mypy: v1.13.0 → v1.18.2](pre-commit/mirrors-mypy@v1.13.0...v1.18.2) - [github.com/codespell-project/codespell: v2.3.0 → v2.4.1](codespell-project/codespell@v2.3.0...v2.4.1) - [github.com/python-jsonschema/check-jsonschema: 0.30.0 → 0.34.1](python-jsonschema/check-jsonschema@0.30.0...0.34.1)
for more information, see https://pre-commit.ci
19101f3 to
da7d673
Compare
Member
matthewfeickert
left a comment
There was a problem hiding this comment.
Thanks for the fixes @kratsg. I have a few questions on:
- How you feel about keeping some things with
_prefixes for maintainer readability in the future. - If we need
get_backend()calls at all if they aren't setting anything. - Why an
assertwas added.
Co-authored-by: Matthew Feickert <matthew.feickert@cern.ch>
* Add test to cover missing ElementTree root handling.
c.f. B108: hardcoded_tmp_directory Flagged by Codecov
kratsg
approved these changes
Nov 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
updates:
Before Merging
For the PR Assignees: