fix: Add temporary upper bounds on NumPy and SciPy to pass tests#2592
Merged
fix: Add temporary upper bounds on NumPy and SciPy to pass tests#2592
Conversation
This reverts commit 0b352ca.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2592 +/- ##
==========================================
+ Coverage 98.21% 98.23% +0.02%
==========================================
Files 69 69
Lines 4543 4545 +2
Branches 804 612 -192
==========================================
+ Hits 4462 4465 +3
Misses 48 48
+ Partials 33 32 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Closed
1 task
kratsg
approved these changes
Jul 18, 2025
Contributor
|
bypassing rules as docs are expected to fail and will be fixed in a different PR. |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
To get development up and running again without having to deal with additional changes yet to the codebase, just get the existing code passing without changing library code and then go from there. We should then pull in the parts of @kratsg's PR #2566 that are needed. Docs will get fixed in another PR.
Resolves #2553
click.testing.CliRunnerto work with versions of Click older than v8.2.0.--enable-cudaflag that can be passed to let CUDA backends be turned on.pyhfCLI command with no arguments from Docker image test as it results in an exit code of 2.Checklist Before Requesting Reviewer
Before Merging
For the PR Assignees: