Skip to content

style: fix up tests#2691

Open
kratsg wants to merge 7 commits intomainfrom
feat/extendedRulesPartTroix
Open

style: fix up tests#2691
kratsg wants to merge 7 commits intomainfrom
feat/extendedRulesPartTroix

Conversation

@kratsg
Copy link
Copy Markdown
Contributor

@kratsg kratsg commented Apr 4, 2026

Pull Request Description

Fixes up stylistic changes for validation and tests. Third in sequence: #2688, #2690.

Checklist Before Requesting Reviewer

  • Tests are passing
  • "WIP" removed from the title of the pull request
  • Selected an Assignee for the PR to be responsible for the log summary

Before Merging

For the PR Assignees:

  • Summarize commit messages into a comprehensive review of the PR
* tests: fixes ARG001, ARG002, PLR0124, and PT012
* validation: fixes PTH123

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.27%. Comparing base (7ec8a21) to head (d9718c0).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2691   +/-   ##
=======================================
  Coverage   98.27%   98.27%           
=======================================
  Files          65       65           
  Lines        4289     4289           
  Branches      461      461           
=======================================
  Hits         4215     4215           
  Misses         46       46           
  Partials       28       28           
Flag Coverage Δ
contrib 98.15% <ø> (ø)
doctest 98.27% <ø> (ø)
unittests-3.10 96.45% <ø> (ø)
unittests-3.11 96.45% <ø> (ø)
unittests-3.12 96.45% <ø> (ø)
unittests-3.13 96.45% <ø> (ø)
unittests-3.9 96.52% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@matthewfeickert matthewfeickert force-pushed the feat/extendedRulesPartTroix branch from e772fd9 to a5ebb55 Compare April 7, 2026 19:50
@kratsg kratsg marked this pull request as ready for review April 8, 2026 06:41
@kratsg kratsg requested a review from matthewfeickert April 8, 2026 06:42
@kratsg kratsg self-assigned this Apr 8, 2026
@kratsg kratsg added the style Changes that do not affect the meaning of the code label Apr 8, 2026
@github-project-automation github-project-automation bot moved this to In progress in pyhf v0.8.0 Apr 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

style Changes that do not affect the meaning of the code

Projects

Status: In progress

Development

Successfully merging this pull request may close these issues.

1 participant