Skip to content

Added ability to specify figsize for matplotlib#578

Open
jzking wants to merge 1 commit intoscikit-learn-contrib:masterfrom
jzking:condensed-plot-size
Open

Added ability to specify figsize for matplotlib#578
jzking wants to merge 1 commit intoscikit-learn-contrib:masterfrom
jzking:condensed-plot-size

Conversation

@jzking
Copy link
Copy Markdown

@jzking jzking commented Dec 9, 2022

Plot size variable added to CondensedTree.plot to pass to matplotlib.figsize for convenience.

@lmcinnes
Copy link
Copy Markdown
Collaborator

lmcinnes commented Dec 9, 2022

I think in practice if you specify a particular plot size then you probably want to create a new figure and specify the figsize explicitly for the figure on creation.

@jzking
Copy link
Copy Markdown
Author

jzking commented Dec 9, 2022

My apologies but I am not very well versed in matplotlib nuances. However, I thought specifying plot size in the call to plot made intuitive sense. Perhaps the way I'm implementing it here is not appropriate for general users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants