Fix compilation warnings#691
Open
Rhaedonius wants to merge 3 commits intoscikit-learn-contrib:masterfrom
Open
Conversation
added 3 commits
October 13, 2025 21:57
force_all_finite has been deprecated in scikit-learn 1.6.0 and will be removed in the upcoming 1.8.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just a couple of very minor tweaks to address warnings during builds:
nogilat the end of the declaration#define NPY_NO_DEPRECATED_API NPY_1_7_API_VERSIONto ensure we're not building against deprecated functions and fail in case they are usedtest_suiteandtest_requireshave been deprecated for a while and have been removed from setup.py