Skip to content

Reorganize the script scil_bundle_label_map#1288

Open
EmmaRenauld wants to merge 2 commits into
scilus:masterfrom
EmmaRenauld:bundles3
Open

Reorganize the script scil_bundle_label_map#1288
EmmaRenauld wants to merge 2 commits into
scilus:masterfrom
EmmaRenauld:bundles3

Conversation

@EmmaRenauld
Copy link
Copy Markdown
Contributor

  • Sent some parts into functions
  • Added a lot of comments

@frheault , I still have a question. Can you check the todo at line 329?

@EmmaRenauld EmmaRenauld requested a review from frheault December 2, 2025 19:13
@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 2, 2025

Codecov Report

❌ Patch coverage is 72.97297% with 20 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.55%. Comparing base (b96d910) to head (1c8260a).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1288      +/-   ##
==========================================
+ Coverage   72.50%   72.55%   +0.04%     
==========================================
  Files         300      300              
  Lines       26097    26090       -7     
  Branches     3662     3654       -8     
==========================================
+ Hits        18922    18929       +7     
+ Misses       5633     5626       -7     
+ Partials     1542     1535       -7     
Flag Coverage Δ
smoketests 69.77% <72.97%> (+0.04%) ⬆️
unittests 14.00% <1.35%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Scripts 75.36% <79.41%> (+0.10%) ⬆️
Library 69.18% <67.50%> (-0.01%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Contributor

@arnaudbore arnaudbore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants