Addition of warnings about shells choices in FRF and FODF fit#1336
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #1336 +/- ##
==========================================
- Coverage 72.51% 72.49% -0.02%
==========================================
Files 300 300
Lines 26105 26139 +34
Branches 3662 3671 +9
==========================================
+ Hits 18929 18949 +20
- Misses 5633 5640 +7
- Partials 1543 1550 +7
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
arnaudbore
reviewed
May 20, 2026
Contributor
arnaudbore
left a comment
There was a problem hiding this comment.
Few comments, It's going to be a fast merged PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quick description
This is a manual extraction from my work on StatefulImage once I realized that it is very easy to provide inaccurate shells in our scripts. While mrtrix take hard decisions (always pick the highest shells) in SSST, we do not. We trust the user, but we should at least warn users. There is a heuristic to determine if the provided shells are too far apart. If the delta between shells is higher than the smallest non-zero: warning
(A file with b800 and b1200 is fine, but b700 and b2000 are too big)
In addition to the problem, but to the 'weird' FODF being produced by our SSST when shells were too far apart, there was a warning in our tracking script that detected these 'weird' FODF as peaks, so I also improved the heuristic to distinguish peaks (often of length 15) from FODF (at SH order 4, also length 15). However, when FRF/FODF process with appropriate shells, this was rarely an issue.
...
Type of change
Check the relevant options.
Provide data, screenshots, command line to test (if relevant)
...
Checklist