build: add support for cross-compiled rpms#4649
Merged
jiceathome merged 6 commits intoscionproto:masterfrom Nov 5, 2024
Merged
build: add support for cross-compiled rpms#4649jiceathome merged 6 commits intoscionproto:masterfrom
jiceathome merged 6 commits intoscionproto:masterfrom
Conversation
This is enabled by a pending PR to the rules_pkg project: bazelbuild/rules_pkg#729 I just added the patch to out build while we wait for the PR to get merged.
Contributor
Author
|
This change is |
There's a bug in some earlier rpmbuild versions that needs to be given a default value for _smp_build_cpus. Hence the "defines" parameter and hence the upgrade by 1 version and hence the update to the patch.
lukedirtwalker
approved these changes
Nov 5, 2024
Collaborator
lukedirtwalker
left a comment
lukedirtwalker
left a comment
There was a problem hiding this comment.
Reviewed 1 of 4 files at r1, 5 of 5 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @jiceatscion)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is enabled by a pending PR to the rules_pkg project: bazelbuild/rules_pkg#729
I just added the patch to our build while we wait for the PR to get merged.