feat: add 3rd-party fallback completion loaders - #1717
Merged
Conversation
The "pew shell_config" command contains initialization [3] of PS1 as well as the completion setting [2]. To prevent it from rewriting PS1 during the completion, we localize the variable PS1. [1] https://github.com/pew-org/pew#bashzsh [2] https://github.com/pew-org/pew/blob/b140a9a869c1f972b43fb8f2269bf41d8ac9500e/pew/shell_config/complete.bash [3] https://github.com/pew-org/pew/blob/b140a9a869c1f972b43fb8f2269bf41d8ac9500e/pew/shell_config/init.bash [4] Bash-it/bash-it#1076
akinomyoga
changed the title
scop
approved these changes
Aug 6, 2026
scop
left a comment
scop
left a comment
Owner
There was a problem hiding this comment.
gocomplete is not too well up to date and pew's behavior is a bit icky, but LGTM
Owner
|
Ah, pew was mentioned in the edited initial description. I think we can live with that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are taken from trivial completion settings in Bash-it. See the respective commit messages. The completion loader for
pew(dfcd673) can be controversial (see the description in the commit message).