Skip to content

Fixed Color Issue in Dark Mode #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fixed Color Issue in Dark Mode #127

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0251ce3
Fixed Color Issue in Dark Mode
hs05june Mar 13, 2023
da18480
Removed a comment
hs05june Mar 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file added imagelab_electron/assets/logos/Image Lab icon.ico
View file
Open in desktop
Binary file not shown.
9 changes: 5 additions & 4 deletions imagelab_electron/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
<meta charset="UTF-8" />
<meta http-equiv="X-UA-Compatible" content="IE=edge" />
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<link rel="icon" href="./assets/logos/Image Lab icon.ico" />
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this file name conventionable? Please use a proper naming convention for file imports (CamelCase or snake_case)

<title>Image Lab</title>

<!-- blockly package -->
Expand Down Expand Up @@ -209,7 +210,7 @@
class="mdi mdi-play-circle-outline"
style="
font-size: 30px;
color: #367930;
color: var(--execute-button-color);
vertical-align: super;
"
></span>
Expand All @@ -219,7 +220,7 @@
class="mdi mdi-undo"
style="
font-size: 30px;
color: #000000;
color: var(--icon-color);
vertical-align: super;
"
></span>
Expand All @@ -229,7 +230,7 @@
class="mdi mdi-redo"
style="
font-size: 30px;
color: #000000;
color: var(--icon-color);
vertical-align: super;
"
></span>
Expand All @@ -239,7 +240,7 @@
onclick="resetWorkspace()"
style="
font-size: 30px;
color: #bb1010;
color: var(--reset-button-color);
vertical-align: super;
"
></span>
Expand Down
6 changes: 6 additions & 0 deletions imagelab_electron/styles/style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,9 @@
--label-color: white;
--category-color: #035fbb;
--wave-color: #1b2440;
--icon-color: #000000;
--execute-button-color: #367930;
--reset-button-color: #bb1010;
}

/* Dark mode colors used in building UI*/
Expand All @@ -26,6 +29,9 @@
--label-color: white;
--category-color: #1f2b4b;
--wave-color: #e8f2fc;
--icon-color: #f1f1f1;
--execute-button-color: #23e700;
--reset-button-color: #ff0000;
}

/* =================================================================*/
Expand Down