-
Notifications
You must be signed in to change notification settings - Fork 0
Ensure test tables are cleanup up on test teardown #36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
5076d8c
to
fb93e0a
Compare
452400e
to
6c03a10
Compare
6c03a10
to
9cb469b
Compare
Did you check these INLINEABLE pragmas do what they're supposed to? |
Did just now against the example target in the cabal file. Comparing core, it expectedly increases the amount of core generated and it generated specializations of For threads where the idea is that they run continuously in the background, my intuition is that it would be better to have them be concrete instead of carrying around instance dictionaries (and so GHC can also optimize more aggressively), in exchange for slightly longer compile-time (timed it and it resulted in a 7% increase (5.21s vs 5.58s)). Curious what you think though, it's not like this is a performance focused library, so it doesn't really matter, but it also doesn't hurt.
|
Some small refactors I did while sketching out something similar to #18. No changes in the API have been made, and there should be no observable changes in usage, except we are now also logging the maximum batch size that was possible on each iteration.
See the
CHANGELOG.md
for the full list of changes.