feat: add secp256k1 ecrecover precompile #1078
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hero78119
reviewed
Sep 30, 2025
hero78119
reviewed
Sep 30, 2025
| (false, false) => { | ||
| let mut p1 = secp256k1_mul(&AffinePoint::GENERATOR, u1); | ||
| let p2 = secp256k1_mul(&r_point, u2); | ||
| syscall_secp256k1_add(&mut p1, &p2); |
There was a problem hiding this comment.
Hi @dreamATD could you helps to review the usage here, e.g.
do we need to check p1 != p2 before calling syscall_secp256k1_add ?
Besides, question from @lightsing: does it work for p1 or p2 to be infinite point? or we should handle it before syscall?
hero78119
requested changes
Oct 1, 2025
|
|
||
| // FIXME: do we really need to verify the signature again here? | ||
| // Original: | ||
| // let vk = VerifyingKey::from_affine(pk.to_affine())?; |
There was a problem hiding this comment.
per offline discussion, this operation seems to be the key to bind relation of (prehash, signature, recovery_id) so let retain original functionality
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.