feat(e2e tests): invalid signature penalizes peer #243
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d-block-penalizes-peer
…d-block-penalizes-peer
Base automatically changed from
feat/e2e-tests-invalid-block-penalizes-peer
to
main
August 11, 2025 22:53
…d-signature-penalizes-peer
greged93
approved these changes
Aug 14, 2025
| // Use the signer configured by SignerArgs | ||
| let chain_id = chain_spec.chain().id(); | ||
| self.signer_args.signer(chain_id).await?.map(rollup_node_signer::Signer::spawn) | ||
| None |
There was a problem hiding this comment.
We should probably add a log with warn level here just to notify that the node is running without signer.
There was a problem hiding this comment.
Then this would print for every node start, even if the node is not configured as a sequencer.
Maybe I'm not understanding the previous behavior correctly but I think it is the same. map(rollup_node_signer::Signer::spawn) should only get called when self.signer_args.signer(chain_id).await? is Some(...). If it's None then signer will become None.
The if now has the same behavior except that imo it's a bit easier to understand and it changes the priority of the branches so that we can also manually configure a signer in a test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the following item of #141: