Improve L1 message reorg testing #253
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR mainly does the following:
can_handle_reorgs_while_sequencing
intocan_handle_l1_message_reorg
to test not only sequencing in the presence of L1 reorg but also behavior of a follower node. Made the test much more explicit to assert certain node statesdefault_sequencer_test_scroll_rollup_node_config
so that by default the sequencer in tests does not issue blocks automatically anymore. This is so that tests become more predictable.can_handle_reorgs_while_sequencing
intocan_handle_l1_message_reorg
and making sure that node states are properly tested).