Skip to content

Improve L1 message reorg testing #253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

jonastheis
Copy link
Contributor

@jonastheis jonastheis commented Aug 13, 2025

This PR mainly does the following:

  • refactors can_handle_reorgs_while_sequencing into can_handle_l1_message_reorg to test not only sequencing in the presence of L1 reorg but also behavior of a follower node. Made the test much more explicit to assert certain node states
  • adds a lot of new convenience functionality for e2e tests for waiting for specific events, assert node state, etc
  • adjusts default_sequencer_test_scroll_rollup_node_config so that by default the sequencer in tests does not issue blocks automatically anymore. This is so that tests become more predictable.
  • fixes issue where an L1 reorg was not properly handled within the engine driver, leading to no L2 reorg taking place even if an L1 message was reorged. (this was discovered by refactoring the can_handle_reorgs_while_sequencing into can_handle_l1_message_reorg and making sure that node states are properly tested).

@jonastheis jonastheis changed the title Implement L1 message reorg test and add functions for test convenience Improve L1 message reorg testing Aug 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants