build: update checkout action to v5 #1722
Conversation
WalkthroughAll modified GitHub Actions workflows update the checkout action from actions/checkout@v4 to actions/checkout@v5 across various jobs/steps. Some commented examples were updated accordingly. No other steps, logic, or configurations were changed. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
♻️ Duplicate comments (8)
.github/workflows/docker.yml (8)
63-63: Same note as above for self-hosted runners.Ensure the runner group is on the required version.
109-109: Same note as above for self-hosted runners.actions/checkout@v5 requires updated runner binaries.
155-155: Same note as above for self-hosted runners.Confirm runner group version compliance.
201-201: Same note as above for self-hosted runners.Runner version must meet v5 requirements.
247-247: Same note as above for self-hosted runners.Please verify the runner group’s minimum version.
293-293: Same note as above for self-hosted runners.v5 compatibility depends on runner version.
339-339: Same note as above for self-hosted runners.Double-check runner fleet upgrade status.
384-384: Same note as above for self-hosted runners.All jobs in this workflow should be covered by the upgrade verification.
🧹 Nitpick comments (4)
.github/workflows/coordinator.yml (1)
80-80: Commented example also updated to v5Keeping commented blocks in sync avoids future copy/paste regressions. Good catch.
If the commented docker-build block is intentionally disabled long-term, consider removing it or linking to a canonical example to reduce maintenance overhead.
.github/workflows/rollup.yml (1)
39-39: Checkout v5 upgrade LGTM; no breaking changes expected on ubuntu-latest.Using actions/checkout@v5 is compatible with GitHub-hosted ubuntu-latest runners and aligns with the Node 24 runner updates goal.
Optionally harden supply chain by pinning actions to a specific commit SHA (GitHub security best practice) and annotating the major version in a comment.
.github/workflows/common.yml (1)
40-40: Checkout@v5 upgrade looks good.GitHub-hosted ubuntu-latest runners meet the minimum version; no breaking changes expected.
Consider pinning actions to a commit SHA to harden against supply-chain risks.
.github/workflows/docker.yml (1)
17-17: Verify self-hosted runner version meets checkout v5 minimum.This workflow runs on a self-hosted runner group (scroll-reth-runner-group). actions/checkout@v5 requires a sufficiently recent GitHub Actions Runner (the PR notes v2.327.1+). Please ensure all runners in this group are upgraded before merging to avoid step failures.
Optional: Pin actions to commit SHAs for supply-chain hardening across this workflow.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (9)
.github/workflows/bridge_history_api.yml(3 hunks).github/workflows/bump_version.yml(1 hunks).github/workflows/common.yml(3 hunks).github/workflows/coordinator.yml(4 hunks).github/workflows/database.yml(3 hunks).github/workflows/docker.yml(9 hunks).github/workflows/integration.yml(1 hunks).github/workflows/intermediate-docker.yml(1 hunks).github/workflows/rollup.yml(4 hunks)
🔇 Additional comments (16)
.github/workflows/coordinator.yml (3)
44-44: Checkout v5 update is correctNo functional changes otherwise; the step will continue to behave the same.
59-59: Second checkout upgrade to v5 — consistent across jobsConsistent with the PR objective; no issues spotted.
100-100: Tests job uses checkout v5 — OKNo additional adjustments required here.
.github/workflows/database.yml (3)
37-37: Checkout updated to v5 — OKNo behavior changes expected for default usage.
52-52: goimports-lint job aligned to checkout v5Consistent with other jobs; looks good.
77-77: Tests job aligned to checkout v5All database workflow jobs consistently migrated. Good.
.github/workflows/intermediate-docker.yml (1)
77-77: Verify self-hosted runner versions for checkout@v5The GitHub CLI check returned a 403, so automatic validation couldn’t confirm runner versions. Before merging, please manually ensure every self-hosted runner in
scroll-reth-runner-groupis running Actions Runner ≥ 2.327.1.• File:
.github/workflows/intermediate-docker.yml
• Line: 77 (uses: actions/checkout@v5).github/workflows/bump_version.yml (1)
19-19: Checkout updated to v5 — OKDefault usage; no additional inputs required. Note: this job also installs Node 16 for project scripts, which is independent of the action runtime used by checkout v5.
.github/workflows/rollup.yml (3)
63-63: Consistent upgrade to actions/checkout@v5.Change is correct and consistent with the PR objective.
88-88: Upgrade confirmed; safe on GitHub-hosted runners.This step also runs on ubuntu-latest; no additional changes needed.
120-120: Nice touch keeping commented example in sync.Prevents future drift if the block is re-enabled.
.github/workflows/bridge_history_api.yml (3)
37-37: Checkout bumped to v5 as intended.No other step changes; ubuntu-latest satisfies runner requirements for v5.
51-51: LGTM: actions/checkout@v5.Consistent with the rest of the repo-wide upgrade.
70-70: LGTM: v5 applied to goimports-lint job.No further action needed.
.github/workflows/common.yml (2)
59-59: Consistent v5 usage.Matches the PR scope; no issues spotted.
84-84: LGTM on tests job.Upgrade is correct and complete here as well.
| @@ -24,7 +24,7 @@ jobs: | |||
| with: | |||
| go-version: 1.21.x | |||
| - name: Checkout code | |||
| uses: actions/checkout@v4 | |||
| uses: actions/checkout@v5 | |||
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chain
Checkout upgraded to v5 — looks good; confirm no remaining v4 references and runner compatibility
- For GitHub-hosted ubuntu-latest, the Actions runner version requirement for checkout v5 is satisfied automatically.
- Recommend scanning the repo to ensure no lingering actions/checkout@v4 references remain.
Run this to verify coverage across the repo:
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "Occurrences of actions/checkout@v4:"
rg -n --hidden --glob '!.git' $'uses: *actions/checkout@v4' || echo "None 🎉"
echo
echo "All occurrences of actions/checkout usage (sanity check):"
rg -n --hidden --glob '!.git' $'uses: *actions/checkout@'Length of output: 2443
Ensure consistent Checkout version across workflows
Our scan confirms there are no lingering actions/checkout@v4 references—great! However, there is one remaining older version:
.github/workflows/docker-coordinator-api-arm64.yml:21usesactions/checkout@v2
Please update this to actions/checkout@v5 to match the rest of your workflows and leverage the latest fixes and features.
🤖 Prompt for AI Agents
In .github/workflows/docker-coordinator-api-arm64.yml around line 21, the
workflow uses actions/checkout@v2 which is inconsistent with the rest of the
repo; update that line to actions/checkout@v5 so all workflows use the same,
current checkout action version.
Bumps checkout to v5 for future-proofing against Node 24 runner updates. Requires runner v2.327.1+. Workflows compile the same.
More info: https://github.com/actions/checkout/releases/tag/v5.0.0
Summary by CodeRabbit