Skip to content

performance: Refactor BasePlot & subclasses to copy less #3757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

dorzhey
Copy link

@dorzhey dorzhey commented Aug 3, 2025

  • Closes #3718
  • [Tests][plotting] this is a pure refactor of plotting internals, no new behavior, and all existing plotting tests pass locally (the one failing heatmap test also fails on main in my environment).
  • Release notes not necessary because: there are no user-facing API changes, only internal performance and memory optimizations.

@dorzhey
Copy link
Author

dorzhey commented Aug 3, 2025

Ah, I failed some of the style checks. I apologize, pre-commit does not work on my environment for some reason, gives error with UTF encoding and tests fail on main

@flying-sheep
Copy link
Member

no worries, I fixed it for you

@flying-sheep flying-sheep changed the title Refactor BasePlot & subclasses per issue 3718 performance: Refactor BasePlot & subclasses to copy less Aug 8, 2025
@flying-sheep
Copy link
Member

OK, I got rid of the “converting index to string” warnings that obscured the actual test failures, so you should be able to see which tests failed now: https://github.com/scverse/scanpy/actions/runs/16826467121/job/47664011892?pr=3757#step:6:7989

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants