-
Notifications
You must be signed in to change notification settings - Fork 8
Allow packages with no logo #171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Packages names can also be capitalized now as their names will be converted to lowercase to fetch the correct icon files based on the package name.
✅ Deploy Preview for jade-cajeta-1bcca0 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Citing from the Zen of Python, even though this is a different language: "Explicit is better than implicit". I am not sure that having a |
This would also make for a more flexible setup. E.g., with the current code with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! I would have sworn that I had used the scverse logo also on the main page for SnapATAC2. But uhm apparently not?
If we don't show a logo, we have an inconsistency because on https://scverse.org/packages/#core-packages we show the scverse logo for SnapATAC2. I had wanted to do the same for the main page.
I don't have a strong opinion on this but I totally trust Malte and would encourage you to consider what he says.
Thank you @gtca !
I think explicit logo paths is the way to go, and it is the thing for the packages page. (It is an implicit link to the filename Thanks both for your comments! |
I like when there’s one source of truth and it’s impossible to e.g. both specify But I also think that the presence of a file is an explicit thing, not an implicit one. If we want locality, we could maybe have one folder per package with both logo and metadata inside, and deleting or adding a folder would remove or add a package. But idk if Hugo supports globbing like that. |
no_icon = true
can now be added to the package information to render them appropriately on the main page.Package names can also be capitalized now as their names will be converted to lowercase to fetch the correct icon files based on the package name.
Though I think all-lowercase is something we should keep, maybe in the case of
snapatac2
vsSnapATAC2
it is a bit too much.