Conversation
resolves se-sic/VaRA#966
resolves se-sic/VaRA#965
resolves se-sic/VaRA#973 Co-authored-by: Lauritz Timm <s9latimm@stud.uni-saarland.de>
… to add child to a feature when in tree view
LuAbelt
reviewed
Aug 29, 2023
LuAbelt
left a comment
There was a problem hiding this comment.
Apart from what Flo and Lauritz already mentioned, some small things I found while using the editor (Mostly minor inconveniences):
- Newly added features don't appear in the TreeView
- When navigating through the TreeView with the arrow buttons the information panel does not update
- When adding new features it can happen that these are created outside of the navigatable area in the GraphView
- Clicking AddSource for a feature without source file creates an "empty" (Displayed as
[:1:1-:1-1]) location - The current filter for C files in the add source file dialog might be too restrictive for some projects (E.g. Dune uses
.hhand.cc, other extensions that come to mind currently not included are.hpp,.cxx,.cpp). I think the most flexible way to handle this is to just add an additional filter to the dialog that displays all files. Then you also don't run into any issues when some projects might use non-standard fiel endings - It would be nice to also be able to create new feature models from scratch
- When saving it would be more convenient if it just saves the current feature model to it's known location without opening the file dialog everytime. The current behavior could be retained with a "Save as" functionality
|
Another thing I just noted that is not only an inconvenience: The |
LuAbelt
reviewed
Sep 18, 2023
added 5 commits
September 26, 2023 10:27
… the memory managment
added 7 commits
November 20, 2023 13:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a gui tool to view featuremodels including the sources for features and edit them.