Fix issues with allocation #271
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alwin-joshy
force-pushed
the
fixed_allocation
branch
3 times, most recently
from
1521ead to
9f74862
Compare
Fixed allocations, which need to be allocated at a specific physical address, were being allocated after regular allocations, which can be allocated at arbitrary addresses. This meant that regular allocations occasionally stole the memory needed by fixed allocations, which resulted in a runtime error. This patch ensures that all fixed allocations are completed before normal allocations Signed-off-by: Alwin Joshy <joshyalwin@gmail.com>
Ivan-Velickovic
force-pushed
the
fixed_allocation
branch
from
9f74862 to
f00e1dd
Compare
Prior to this patch, fixed and regular allocations used two different allocation methods, FixedUntypedAlloc and ObjectAllocator respectively. These operated on the same underlying untyped objects but did not maintain coherency about how much of the untyped had already been allocated, which lead to runtime invocation errors when an untyped contains both fixed and regular allocations. This patch removes FixedUntypedAlloc and changes everything to use ObjectAlloc. Signed-off-by: Alwin Joshy <joshyalwin@gmail.com> Signed-off-by: Ivan-Velickovic <i.velickovic@unsw.edu.au>
Ivan-Velickovic
force-pushed
the
fixed_allocation
branch
from
f00e1dd to
941fc73
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a couple of bugs related to allocations that are fixed to a particular physical address.