Disable TIMEOUTFAULT0003 for simulation #146
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lsf37
approved these changes
Aug 12, 2025
Member
lsf37
left a comment
lsf37
left a comment
There was a problem hiding this comment.
Looks good from my side. (Style failure still to fix up)
It is very timing sensitive and relies on non-guaranteed ordering of timeout faults. In Qemu it faults about 1 in 10 times for me. Proper long-term fix is to make the test more robust by not assuming ordering of faults, but that requires rewriting a lot of the test code. Signed-off-by: Indan Zupancic <[email protected]>
Indanz
force-pushed
the
TIMEOUTFAULT0003
branch
from
5bf5a5d to
6dc24fc
Compare
Contributor
Author
|
I swear I saw the style check pass when I hit the merge button, but now it complains about: Apologies. :-( |
Member
|
No worries, we can fix it next time. This is one of the cases where |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is very timing sensitive and relies on non-guaranteed ordering of timeout faults. In Qemu it faults about 1 in 10 times for me.
Proper long-term fix is to make the test more robust by not assuming ordering of faults, but that requires rewriting a lot of the test code.