Tests for overmapping, and fixes for aarch32 PT tests #148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alwin Joshy <[email protected]>
Signed-off-by: Alwin Joshy <[email protected]>
Signed-off-by: Alwin Joshy <[email protected]>
Signed-off-by: Alwin Joshy <[email protected]>
Indanz
reviewed
Oct 20, 2025
| cspacepath_t path; | ||
| int error; | ||
|
|
||
| seL4_CPtr pgd = vka_alloc_object_leaky(&env->vka, seL4_ARM_PageGlobalDirectoryObject, 0); |
Contributor
There was a problem hiding this comment.
Since Kent's commit to unify the page table objects, this should be seL4_ARM_VSpaceObject and the others just seL4_ARM_PageTable.
However, backward compatible defines are in libsel4/sel4_arch_include/aarch64/sel4/sel4_arch/deprecated.h. (But they're missing from libsel4/sel4_arch_include/aarch32/sel4/sel4_arch/deprecated.h, not sure if that's intentional.)
Kswin01
changed the title
Signed-off-by: Krishnan Winter <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rebased version of the work done in PR #88
Test with seL4/seL4#1526