Fix RPi4 failing sel4test in Release mode #150
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jakub Duchniewicz <[email protected]>
lsf37
approved these changes
Dec 4, 2025
Member
lsf37
left a comment
lsf37
left a comment
There was a problem hiding this comment.
Nice. Thank you for tracking that down.
After this is merged, we should enable those tests in ci-actions.
Indanz
reviewed
Dec 4, 2025
Contributor
Indanz
left a comment
Indanz
left a comment
There was a problem hiding this comment.
It only costs a little bit of data to have more than the bare minimum and the define is a maximum, not an exact count.
Contributor
|
As for avoiding the same problem in the future: The only way is to add extra margin and initialise UARTs first before other devices, so the error print works. |
Signed-off-by: Jakub Duchniewicz <[email protected]>
Indanz
approved these changes
Dec 4, 2025
Indanz
requested changes
Dec 4, 2025
Contributor
Indanz
left a comment
Indanz
left a comment
There was a problem hiding this comment.
If you rename it, you have to update all users too of course.
/github/workspace/projects/sel4test/apps/sel4test-driver/src/main.c:515:45: error: ‘NUM_ALLOC_AT_TO_TRACK’ undeclared (first use in this function); did you mean ‘MAX_ALLOC_AT_TO_TRACK’?
515 | static uspace_alloc_at_args_t args_prev[NUM_ALLOC_AT_TO_TRACK] = {};
| ^~~~~~~~~~~~~~~~~~~~~
| MAX_ALLOC_AT_TO_TRACK
Signed-off-by: Jakub Duchniewicz <[email protected]>
Indanz
approved these changes
Dec 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the seL4/util_libs#171 issue where in order to have sel4test pass in Release mode for RPi4 one had to comment out GPIO setting. This stems from having just one available allocation to our disposal while we are in
serial_utspace_record == truephase (when the serial driver is being set up).Since there are 2 allocations happening - one for GPIO in
uart_gpio_configureusingMAP_IF_NULLmacro (here), and the other one for UART being done inbcm_uart_init(here). We are running out of available allocations specified byNUM_ALLOC_AT_TO_TRACK.