Repository navigation
feat: migrate to aiohttp and resolve test thread leaks - #4
Merged
Merged
Conversation
seanmccabe
commented
Jan 10, 2026
seanmccabe
commented
Owner
- Replace blocking 'requests' library with 'aiohttp' for all API calls.
- Remove 'requests' from manifest.json.
- Refactor test_coordinator.py, test_init.py, and test_config_flow.py to use AsyncMock and correct patching, permanently resolving aiohttp client session thread leaks during testing.
- Fix logic assertions in configuration flow and coordinator tests to match actual error handling.
- Bump version to 1.2.0-beta.1.
- Update CHANGELOG.md.
- Replace blocking 'requests' library with 'aiohttp' for all API calls. - Remove 'requests' from manifest.json. - Refactor test_coordinator.py, test_init.py, and test_config_flow.py to use AsyncMock and correct patching, permanently resolving aiohttp client session thread leaks during testing. - Fix logic assertions in configuration flow and coordinator tests to match actual error handling. - Bump version to 1.2.0-beta.1. - Update CHANGELOG.md.
- Migrate core networking from requests to aiohttp to fix blocking I/O. - Add 'Last Sync' diagnostic sensor. - Achieve 100% test coverage with new async test suite. - Remove 'requests' dependency. - Fix thread safety issues. - Update documentation and badges.
- Added a force sync with BGG button
…ed-up individual attributes
…ed-up individual attributes
…existing sensors to become unavailable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.