feat(baseline): can ignore deprecations with regex #6287
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikophil
commented
Aug 2, 2025
src/Runner/Baseline/Issue.php
Outdated
| @@ -112,7 +113,7 @@ public function equals(self $other): bool | |||
| return $this->file() === $other->file() && | |||
| $this->line() === $other->line() && | |||
| $this->hash() === $other->hash() && | |||
| $this->description() === $other->description(); | |||
| ($this->description() === $other->description() || preg_match('{' . $this->description() . '}', $other->description) !== false); | |||
There was a problem hiding this comment.
I'm actually wondering if we should use regex, or a simple str_contains(), WDYT? maybe both?
sebastianbergmann
added
the
type/enhancement
|
This pull request proposes a new feature and should therefore target the |
nikophil
force-pushed
the
feat/baseline-with-regex
branch
from
8b00bab to
3ef5f62
Compare
nikophil
force-pushed
the
feat/baseline-with-regex
branch
from
3ef5f62 to
35d4338
Compare
|
@sebastianbergmann done |
|
Thank you for your contribution. I appreciate the time you invested in preparing this pull request. However, I have decided not to merge it as I fail to see the benefit. The baseline file is not supposed to be written or edited manually, it must only be generated using the |
|
@sebastianbergmann damn you're right I think I did mix up the two concepts which Symfony's PHPunit bridge offers:
sorry for wasting your time 😬 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it could be nice to be able to ignore deprecations using regex: see for instance doctrine/deprecations: they do insert the line number in their deprecation messages. Meaning that if they change some code in the file, if PHPUnit is not able to ignore deprecations based on regex, the code would break