Take #[IgnorePhpunitDeprecations] attribute into account for test runner deprecations #6331
Conversation
|
@sebastianbergmann your initial commit was not accompanied by a test-case. do you know what was the motivation for the initial commit so we can properly test it? |
| @@ -0,0 +1,29 @@ | |||
| --TEST-- | |||
There was a problem hiding this comment.
added this test from #6304 (comment) which seems to not find its way into the codebase?
sebastianbergmann
added
type/enhancement
|
@jcandan @mably @fjgarlin @cmlara @jrfnl this PR re-adds a reworked commit which caused problems for you in #6304 could you please double check the new version of the initial fix will not lead to the same problems in your projects? I tried to cover it with tests as good as possible, based on the information given at issue 6304. |
|
@staabm Thanks for the ping. Without an opinion on the functionality in the PR.... tested locally on Windows 10 and I don't see the "hanging" anymore. Tried to test in CI on Linux too, but am running into rate limits. Will report back once I get CI running again. |
|
This looks good to me, thank you for working on this. However, for the |
|
Merged manually, thanks. |
similar to b3be029 but with a fix to prevent the endless loop we saw in #6304 (comment)
closes #6329