refactor job conf and project conf #691
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @tyrone-yu, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request refactors the configuration structures by expanding the ProjectConfig with several new fields related to session logging, PSI algorithms, communication modes, batching, and time zones. Correspondingly, JobConfig has also been updated to include some of these new options, and a clarifying comment has been added to define the relationship between JobConfig and ProjectConfig. The changes aim to enhance the flexibility and clarity of job and project configuration management.
Highlights
- Project Configuration Expansion: The
ProjectConfigmessage inapi/broker.protohas been extended to include new fields such asenable_session_logger_separation,psi_type,use_rr22_low_comm_mode,batched, andtime_zone. This centralizes more job-related configuration options within the project-level settings. - Job Configuration Updates: The
JobConfigmessage has been updated to includeuse_rr22_low_comm_modeandbatchedfields, aligning it with some of the new project-level configurations. - Configuration Relationship Clarification: A new comment has been added to
api/broker.protoexplicitly stating thatJobConfigis a subset ofProjectConfig, improving clarity on their relationship.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request refactors ProjectConfig and JobConfig in api/broker.proto to align their structures, with the stated goal of making JobConfig a subset of ProjectConfig. New configuration fields are also introduced.
I've pointed out a minor type inconsistency for the enable_session_logger_separation field which goes against the subset goal.
A more significant concern is that this PR seems incomplete. The Go code that uses these configurations isn't updated to handle the new fields. For example, new fields in ProjectConfig are not read, and new fields in JobConfig are not propagated. This makes the new configurations non-functional. I assume the code changes to use these new configurations will be in a subsequent PR.
| optional bool reveal_group_mark = 9; | ||
| // reveal the number of elements in each group | ||
| optional bool reveal_group_count = 10; | ||
| optional bool enable_session_logger_separation = 11; |
There was a problem hiding this comment.
什么场景下需要用 optional？
有的字段用了：group_by_threshold 有的没有：psi_curve_type
There was a problem hiding this comment.
如果无法区分没配置还是配置的默认值的，就用的 optional
比如 reveal_group_count 配置为 false，和不配置，在不用 optional 的情况下无法区分，加了 optional 之后，不配置会产生一个空指针，可以区分
4 participants
No description provided.