Creating Resources for new Components and Operators #214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer's GuideThis PR introduces new ReleasePlan definitions for the model-validation-operator and its FBC variant, and sets up Kustomize overlays (with patches and kustomization manifests) for multiple components and versioned FBC overlays. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey there - I've reviewed your changes - here's some feedback:
- The metadata.name fields (e.g. "promote-to-candidate-") are missing their component/version suffixes, please fill in the full resource names.
- In the rhtas-console overlay kustomization, the nameSuffix is still set to "model-transparency" – update it to the correct suffix for rhtas-console.
- There’s a lot of repeated overlay boilerplate for each mvo-fbc version—consider automating or templating these files to reduce duplication.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The metadata.name fields (e.g. "promote-to-candidate-") are missing their component/version suffixes, please fill in the full resource names.
- In the rhtas-console overlay kustomization, the nameSuffix is still set to "model-transparency" – update it to the correct suffix for rhtas-console.
- There’s a lot of repeated overlay boilerplate for each mvo-fbc version—consider automating or templating these files to reduce duplication.
## Individual Comments
### Comment 1
<location> `konflux-configs/releasePlans/promoteToCandidateRPs/components/overlays/rhtas-console/kustomization.yaml:4` </location>
<code_context>
+resources:
+- ../../../components/base
+
+nameSuffix: model-transparency
+
+apiVersion: kustomize.config.k8s.io/v1beta1
</code_context>
<issue_to_address>
The nameSuffix value may be incorrect for rhtas-console overlay.
Update nameSuffix to 'rhtas-console' for clarity and consistency in resource naming.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
...figs/releasePlans/promoteToCandidateRPs/components/overlays/rhtas-console/kustomization.yaml
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Create and organize new ReleasePlan resources and Kustomize overlays to support automated candidate promotions for model-validation-operator, mvo-fbc, and related components
New Features: