fix(build): Make docker-buildx target compatible with podman #1414
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer's guide (collapsed on small PRs)Reviewer's GuideEnhanced the Makefile’s docker-buildx target to support Podman by introducing a conditional branch that uses standard podman build and push commands when CONTAINER_TOOL=podman, while retaining the existing Docker buildx workflow in other cases. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
PR Compliance Guide 🔍(Compliance updated until commit a4add9d)Below is a summary of compliance checks for this PR:
Compliance status legend🟢 - Fully Compliant🟡 - Partial Compliant 🔴 - Not Compliant ⚪ - Requires Further Human Verification 🏷️ - Compliance label Previous compliance checksCompliance check up to commit 77e9184
|
|||||||||||||||||||||||||||||||||||||||||||||||||
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
PR Code Suggestions ✨Explore these optional code suggestions:
|
||||||||||||
osmman
added
bug
osmman
reviewed
Nov 6, 2025
Makefile
Outdated
| .PHONY: docker-buildx | ||
| docker-buildx: ## Build and push docker image for the manager for cross-platform support | ||
| # copy existing Dockerfile and insert --platform=${BUILDPLATFORM} into Dockerfile.cross, and preserve the original Dockerfile | ||
| sed -e '1 s/\(^FROM\)/FROM --platform=\$$\{BUILDPLATFORM\}/; t' -e ' 1,// s//FROM --platform=\$$\{BUILDPLATFORM\}/' Dockerfile > Dockerfile.cross |
Collaborator
There was a problem hiding this comment.
I think that this part is not needed for podman
kdacosta0
force-pushed
the
kdacosta/podman-cross-platform
branch
from
3bd7f13 to
b580f76
Compare
Signed-off-by: Kristian Da Costa Menezes <[email protected]>
kdacosta0
force-pushed
the
kdacosta/podman-cross-platform
branch
from
b580f76 to
a4add9d
Compare
CI Feedback 🧐A test triggered by this PR failed. Here is an AI-generated analysis of the failure:
|
osmman
approved these changes
Nov 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The docker-buildx target was using Docker-specific 'buildx' commands,
which failed when CONTAINER_TOOL was set to 'podman'
Summary by Sourcery
Support Podman for cross-platform image builds by conditionally using standard Podman build and push commands in the docker-buildx Makefile target while retaining Docker buildx for other container tools.
Bug Fixes:
podman buildandpodman pushwhen CONTAINER_TOOL is set to podmanEnhancements: