Closed
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: JasonPowr The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
9fe8c4c to
f485992
Compare
Member
Author
|
After discussing with Aleksy, this seems like it is not worth spending the time trying to get it to work with our downstream for a patch release (1.1.1), the latest versions also did not add much to what we ship. This should be revisited for the next minor release |
Also updated `deny.toml`.
Enable `prebuilt-nasm` feature for Windows. Signed-off-by: Gavin Inglis <giinglis@amazon.com>
Enable `prebuilt-nasm` feature for Windows Signed-off-by: Gavin Inglis <giinglis@amazon.com>
Signed-off-by: Gavin Inglis <giinglis@amazon.com>
aws-lc-rs pins to untrusted v0.7.1; skip this crate in license checks Signed-off-by: Gavin Inglis <giinglis@amazon.com>
add a 'fips' feature to tough crates to enable toggling fips enforcement on crate dependencies. Remove the prebuilt-nasm feature in favor of allowing downstream consumers to set this feature if needed; use setup-nasm in CI for windows integ testing and split out integ testing fips to a new Makefile rule such that it can be skipped in macos testing Signed-off-by: Gavin Inglis <giinglis@amazon.com>
when building the tuftool HTTP client, install the aws_lc_rs default CryptoProvider if none is set yet. This is to ensure that a CryptoProvider for rustls is set before proceeded with HTTP methods. Signed-off-by: Gavin Inglis <giinglis@amazon.com>
Bump reqwest to 0.12 as a prerequisite for FIPS support.
f485992 to
dcbad63
Compare
Member
|
can be canceled after the merge of: #82 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.