Skip to content

Fw wallet security#161

Closed
PatrickAlphaC wants to merge 3 commits intosecurity-alliance:developfrom
PatrickAlphaC:fw_wallet_security
Closed

Fw wallet security#161
PatrickAlphaC wants to merge 3 commits intosecurity-alliance:developfrom
PatrickAlphaC:fw_wallet_security

Conversation

@PatrickAlphaC
Copy link
Copy Markdown
Collaborator

@PatrickAlphaC PatrickAlphaC commented Jul 4, 2025

Made a lot of updates to the wallet security section. I branched from another branch of mine so I wouldn't have to add patrickalphac as a contributor again.

Blocked by: #160

Please only focus on the wallet-security commit here. I can remove 89abdcad590deb4d2b30ff6b3328bbacba837c06 and a9b054cad448f881bebbe22d59f70af84d86ccd4 if that's preferred.

Frameworks PR Checklist

Thank you for contributing to the Security Frameworks! Before you open a PR, make sure to read information for contributors and take a look at the following checklist:

  • Describe your changes, substitute this text with the information
  • If you are touching an existing piece of content, ask the original creator for review
  • If you need feedback for your content from wider community, share the PR in our Discord
  • Review changes to ensure there are no typos, see instructions below

@vercel
Copy link
Copy Markdown

vercel Bot commented Jul 4, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
frameworks ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 4, 2025 6:06pm

@mattaereal
Copy link
Copy Markdown
Collaborator

This PR has now fallen within the realm of @pinalikefruit's tasks. I think a good way to start thinking about how to incorporate this, in a more effortless approach, is to compare this content with current content (maybe using AI), asking where these contents complement, and improve current ones based on these, when it's possible.

wdyt?

@pinalikefruit
Copy link
Copy Markdown
Collaborator

Hi @PatrickAlphaC ,

First of all, thank you for this contribution! I've reviewed the suggested changes and I think that after applying the adjustments I'm about to recommend, they will add great value to the section.

As you may have noticed, #164 was merged recently, which unfortunately creates some conflicts with your current commit. To resolve this, please pull the latest changes from the develop branch and add your contributions there.

You'll see that some of the sections you've worked on have been updated or merged into others. With that in mind, I'd like to recommend focusing your upcoming changes only on the Wallet Security section.

Also, just something to keep in mind: with the latest updates, we're trying to focus the section on providing criteria so the user can choose a secure wallet for themselves, rather than recommending specific products. Any tools or insights that help users in that selection process are super welcome!

I'm here to help if you have any questions or need a hand with anything. Looking forward to collaborating with you.

What do you think?

@PatrickAlphaC
Copy link
Copy Markdown
Collaborator Author

@pinalikefruit thanks!

I made a clean new branch and added some light information here if you could review.

#173

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants