Fix #1387 - refactor win.webContents.executeJavaScript(src) to use promises#1504
Open
jordanhatcher wants to merge 4 commits intosegment-boneyard:masterfrom
Open
Fix #1387 - refactor win.webContents.executeJavaScript(src) to use promises#1504jordanhatcher wants to merge 4 commits intosegment-boneyard:masterfrom
jordanhatcher wants to merge 4 commits intosegment-boneyard:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1387
I followed the suggestions in the issue, and refactored
win.webContents.executeJavaScript(src)to use promises instead of ipc to return the result of the executed Javascript. The issue mentions removing javascript.js, however it looks like it is still necessary to do the string templating there, so it may need to be refactored further.