-
Notifications
You must be signed in to change notification settings - Fork 284
[Vibe] Add Vibe Audience destination #3244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Vibe] Add Vibe Audience destination #3244
Conversation
…t, and sync capabilities - Introduced constants for base URL and API version. - Created generated types for settings and audience settings. - Implemented audience destination definition including authentication and audience management methods. - Developed VibeClient for API interactions, including audience creation and retrieval. - Added sync functionality for audience data. - Included tests for authentication and audience operations. - Established properties for advertiser ID and auth token.
Hi @Max0u thanks for raising this PR for a new Segment Integration. Could you please schedule a workshop with me here? https://calendly.com/joe_ayoub/integration-workshop I'd like to discuss your use-case, your API and the PR itself. It will be a technical meeting where we will likely make changes to the PR. Hopefully we will be able to get it ready to deploy. Kind regards, |
- Simplify Audience sync logic - Audience will be create on the fly by Vibe side - Usage of traits or properties to retrieve personnal informations
name: 'Vibe Audience', | ||
slug: 'actions-vibe-audience', | ||
mode: 'cloud', | ||
description: 'The Vibe Audience destination.', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's go with a better description:
'Sync Segment Engage Audiences to Vibe`
@@ -0,0 +1,2 @@ | |||
export const BASE_URL = 'http://localhost:8101' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just need the correct URL before I can approve and deploy this Integration.
Hello @joe-ayoub-segment, thanks again for your time yesterday! I’ve updated the PR with your comments. I wasn’t sure about your convention regarding comment resolution, so I left them for you to resolve. I also updated the endpoint of our service, the new endpoints should be deployed this afternoon on our side. One last question: the CI failed on required-field-check (22.x). Could you let me know what I should do to fix it? |
Thank you @Max0u - this is ready to be deployed now. You can ignore the required field check thing. I'll deploy the code on Tuesday. |
Hello everyone,
After my discussions with
Ga(niprasad) Niprasad
andTimothy Koeth
, we agreed to move forward with a native action destination.Our goal is to provide your users with a destination to Vibe Audience, enabling them to retarget their users.
I’ve mainly followed the same logic as
facebook-custom-audience
.The new endpoints are not yet deployed, but once they are, I’ll update the base URL. Everything has been tested locally so far, and I’d also like to test the segment creation part locally if possible. Is it possible?
From my understanding, your users will need to enter their Vibe ID and the auth token (which we’ll provide in our UI). Segment will then create all Engage segments on our side and push batches of profiles based on the mapping the user sets. Could you confirm if that’s correct?
Thanks in advance for reviewing this!
Testing
Include any additional information about the testing you have completed to
ensure your changes behave as expected. For a speedy review, please check
any of the tasks you completed below during your testing.