Skip to content

Conversation

Max0u
Copy link
Contributor

@Max0u Max0u commented Sep 8, 2025

Hello everyone,

After my discussions with Ga(niprasad) Niprasad and Timothy Koeth, we agreed to move forward with a native action destination.

Our goal is to provide your users with a destination to Vibe Audience, enabling them to retarget their users.

I’ve mainly followed the same logic as facebook-custom-audience.

The new endpoints are not yet deployed, but once they are, I’ll update the base URL. Everything has been tested locally so far, and I’d also like to test the segment creation part locally if possible. Is it possible?

From my understanding, your users will need to enter their Vibe ID and the auth token (which we’ll provide in our UI). Segment will then create all Engage segments on our side and push batches of profiles based on the mapping the user sets. Could you confirm if that’s correct?

Thanks in advance for reviewing this!

Testing

Include any additional information about the testing you have completed to
ensure your changes behave as expected. For a speedy review, please check
any of the tasks you completed below during your testing.

  • Added unit tests for new functionality
  • Tested end-to-end using the local server
  • [If destination is already live] Tested for backward compatibility of destination. Note: New required fields are a breaking change.
  • [Segmenters] Tested in the staging environment
  • [Segmenters] [If applicable for this change] Tested for regression with Hadron.

…t, and sync capabilities

- Introduced constants for base URL and API version.
- Created generated types for settings and audience settings.
- Implemented audience destination definition including authentication and audience management methods.
- Developed VibeClient for API interactions, including audience creation and retrieval.
- Added sync functionality for audience data.
- Included tests for authentication and audience operations.
- Established properties for advertiser ID and auth token.
@Max0u Max0u requested a review from a team as a code owner September 8, 2025 16:31
@Max0u Max0u changed the title Add Vibe Audience destination [Vibe] Add Vibe Audience destination Sep 8, 2025
@joe-ayoub-segment joe-ayoub-segment self-assigned this Sep 9, 2025
@joe-ayoub-segment
Copy link
Contributor

Hi @Max0u thanks for raising this PR for a new Segment Integration.
I had a quick scan through the code and think that the best next step would be to have a face to face meeting.

Could you please schedule a workshop with me here? https://calendly.com/joe_ayoub/integration-workshop

I'd like to discuss your use-case, your API and the PR itself. It will be a technical meeting where we will likely make changes to the PR. Hopefully we will be able to get it ready to deploy.

Kind regards,
Joe

- Simplify Audience sync logic
- Audience will be create on the fly by Vibe side
- Usage of traits or properties to retrieve personnal informations
name: 'Vibe Audience',
slug: 'actions-vibe-audience',
mode: 'cloud',
description: 'The Vibe Audience destination.',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go with a better description:

'Sync Segment Engage Audiences to Vibe`

@@ -0,0 +1,2 @@
export const BASE_URL = 'http://localhost:8101'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just need the correct URL before I can approve and deploy this Integration.

@Max0u
Copy link
Contributor Author

Max0u commented Sep 12, 2025

Hello @joe-ayoub-segment, thanks again for your time yesterday!

I’ve updated the PR with your comments. I wasn’t sure about your convention regarding comment resolution, so I left them for you to resolve. I also updated the endpoint of our service, the new endpoints should be deployed this afternoon on our side.

One last question: the CI failed on required-field-check (22.x). Could you let me know what I should do to fix it?

@joe-ayoub-segment
Copy link
Contributor

Thank you @Max0u - this is ready to be deployed now. You can ignore the required field check thing. I'll deploy the code on Tuesday.

@joe-ayoub-segment joe-ayoub-segment merged commit 9a6c74d into segmentio:main Sep 15, 2025
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants