feat: Stackbit 1248 camera scanner#839
Open
stackbitme wants to merge 1 commit intoselfcustody:developfrom
Open
feat: Stackbit 1248 camera scanner#839stackbitme wants to merge 1 commit intoselfcustody:developfrom
stackbitme wants to merge 1 commit intoselfcustody:developfrom
Conversation
Add camera-based scanner for Stackbit 1248 metal backup plates. Reads punched dots and decodes BIP39 words automatically. Supports 12/24 word mnemonics and both 1248 and 1248mini plates.
Member
|
Nice @stackbitme! To move on, the PR needs several adjusts to pass tests, I would start with format and linting, then you need to add translations, fix existing tests, and create new ones to cover the added feature. |
Member
|
Hey @odudex, have you tested the PR first? I think it’s better to review the functionality and implementation upfront. If it looks good, then add tests, otherwise @stackbitme may have to redo them after further changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added a camera scanner for Stackbit 1248 metal backup plates. It reads the punched dots and decodes the BIP39 words automatically.
Works with both 12 and 24 word mnemonics, and supports standard 1248 and 1248mini plates.
How to use
Test plan