Conversation
add missing minor changes from previous changelog
adjust BULL coordinator labels and links
* add new device: Embed Fire custom display initialization for Embed Fire * add touchscreen tests not only for Embed Fire * Embed Fire added to simulator and docs (#53) --------- Co-authored-by: Tads <tadeubas@gmail.com>
and videos management
* Update Maixpy to return bytes object from binary QR codes * Update Datum to auto convert, when possible, binary QRs to strings * Ensure addresses become strings when scanned * When encryption-key is scanned, try to decode as str --------- Co-authored-by: Jean Do <117163651+jdlcdl@users.noreply.github.com>
add WonderK to release script
*feat: loading a descriptor sets wallet attributes *feat: remove the feature to load xpubs as they were descriptors, with or without assumptions.
* Simplify internal key validation for taproot There is no standard for how to generate the taproot keypath chaincode to be used with the NUMS pubkey. Liana does it by hashing the taptree keys; Coldcard uses a random chaincode; Nunchuck hashes the taptree keys, but remove duplicates and sort the keys before hashing. This fix changes the verification logic to check only the NUMS pubkey and ignore the chaincode. * Allow loading of non-deterministic chain code in wallet The wallet now loads the non-deterministic chain code without raising an error, indicating it is considered valid.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #840 +/- ##
==========================================
+ Coverage 97.10% 97.31% +0.21%
==========================================
Files 82 83 +1
Lines 10422 10573 +151
==========================================
+ Hits 10120 10289 +169
+ Misses 302 284 -18 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I wouldn’t add commit eee8e95 . It doesn’t provide any real benefit, only invalidates the build cache for everyone. This isn’t really an issue anyway, since once the command succeeds, it’s cached. |
Just testing here. Build script will demand more updates. |
|
If it requires further changes, wouldn’t it be better to open a separate PR for that? |
|
ACK, reviewed the code changes. I can’t mark it as approved since I don’t have the required permissions. |
What is this PR for?
26.03.0 Release