fix: reject PSBT inputs with non-standard sighash types before signing#844
Merged
odudex merged 1 commit intoselfcustody:developfrom Mar 30, 2026
Merged
fix: reject PSBT inputs with non-standard sighash types before signing#844odudex merged 1 commit intoselfcustody:developfrom
odudex merged 1 commit intoselfcustody:developfrom
Conversation
Adds pre-sign validation that refuses to sign if any input requests SIGHASH_NONE, SIGHASH_SINGLE, or ANYONECANPAY, which could allow an attacker to redirect funds after signing. Addresses security audit C2 of selfcustody#843
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #844 +/- ##
========================================
Coverage 97.31% 97.31%
========================================
Files 83 83
Lines 10573 10581 +8
========================================
+ Hits 10289 10297 +8
Misses 284 284 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
ACK 08036f0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Although Embit already refuses to sign inputs with non-ALL sighash by default, this adds a redundant pre-sign validation that refuses to sign if any input requests SIGHASH_NONE, SIGHASH_SINGLE, or ANYONECANPAY, which could allow an attacker to redirect funds after signing. Addresses security audit C2 of #843
Changes made to:
Did you build the code and tested on device?
What is the purpose of this pull request?